Populate primary_key field for joined tables
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
changed the title
primary_key field for tablesprimary_key field for joined tables
This was
linked to
issues
Oct 18, 2024
sfc-gh-cnivera
requested review from
sfc-gh-rehuang,
sfc-gh-jsummer and
sfc-gh-twhite
as code owners
sfc-gh-ybsat
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joins now require a
primary_keyto be specified on the table objects being used in the joins. When using the join editor, we now attempt to populate theprimary_keyfield on the table by using ashow primary keys in table...query. If this query returns no results, we simply set an empty string column for the user to fill out.