Parse semantic model into select statements #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jhilgart
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang and
sfc-gh-nlimtiaco
as code owners
sfc-gh-nsehrawat
approved these changes
Apr 17, 2024
| col: Union[TimeDimension, Dimension, Measure], cols: Set[str] | ||
| ) -> Optional[str]: | ||
| # TODO(jhilgart): Handle quoted names properly. | ||
| if col.name.lower() not in cols: |
There was a problem hiding this comment.
I think we can drop this check and all the cols: Str[str] arguments for these methods. Because here we just need to generate a select statement with one expression per logical column.
There was a problem hiding this comment.
makes sense
| ) | ||
|
|
||
| measure_example = Measure( | ||
| name="Total Sales", |
There was a problem hiding this comment.
We should stick to names without spaces for now - they'll work here but we don't properly handle them downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the semantic model into select statements.
This will only verify that we have columns for all tables. Next, we'll execute queries.