Initial commit to push semantic model generator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jhilgart
commented
Apr 8, 2024
| # semantic-model-generator |
There was a problem hiding this comment.
@sfc-gh-pverhoeven Please review
semantic_model_generator/main.py
Outdated
| populates them with sample values, and sets placeholders for descriptions and filters. | ||
| """ | ||
|
|
||
| # For each columns, decide if it is a TimeDimension, Measure, or Dimension column. |
There was a problem hiding this comment.
I think this is ok. wdyt
semantic_model_generator/snowflake_utils/snowflake_connector.py
Outdated
Show resolved
Hide resolved
semantic_model_generator/snowflake_utils/snowflake_connector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Pieter Verhoeven <[email protected]>
Co-authored-by: Pieter Verhoeven <[email protected]>
sfc-gh-jhilgart
requested review from
sfc-gh-pverhoeven,
sfc-gh-nsehrawat and
sfc-gh-rehuang
sfc-gh-nsehrawat
approved these changes
Apr 9, 2024
README.md
Outdated
|
|
||
|
|
||
| ```bash | ||
| python -m semantic_model_generator.main \ | ||
| --fqn_tables "['<your-database-name-1>.<your-schema-name-1>.<your-table-name-1>','<your-database-name-2>.<your-schema-name-2>.<your-table-name-2>']" \ | ||
| --fqn_tables "['<your-database-name-1>.<your-schema-name-1>.<your-physical-table-name-1>','<your-database-name-2>.<your-schema-name-2>.<your-physical-table-name-2>']" \ | ||
| --semantic_model_name "<a-meaningful-semantic-name-for-your-team>" \ |
There was a problem hiding this comment.
WDYT about s/a-meaningful-semantic-name-for-your-team/a-meaningful-semantic-model-name?
README.md
Outdated
|
|
||
| In addition, consider adding the following elements to your semantic model: | ||
|
|
||
| 1. Logical columns for a given table. |
There was a problem hiding this comment.
Should we say, "Logical columns that are expressions over physical columns"? Since all columns in a semantic model are logical columns.
There was a problem hiding this comment.
good point - done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial commit to move over the relevant files to the
semantic-model-generatorrepo.