Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: defer to SNOWFLAKE_TOKEN environment variable if set instead of fetching an Oauth token #293

Closed
wants to merge 1 commit into from
Closed

feat: defer to SNOWFLAKE_TOKEN environment variable if set instead of fetching an Oauth token #293

wants to merge 1 commit into from

Conversation

zanebclark
Copy link

@zanebclark
Copy link
Author

@sfc-gh-tmathew @jamesweakley @sfc-gh-jhansen, another one with test cases

@sfc-gh-jhansen
Copy link
Collaborator

Looks good, thanks! Please see my comments on #285 about getting the tests to pass.

@zanebclark
Copy link
Author

@sfc-gh-tmathew and @sfc-gh-jhansen, flagging a few 4.0.0 candidates.

@zanebclark
Copy link
Author

Closing in favor of #298

@zanebclark zanebclark closed this Nov 18, 2024
@zanebclark zanebclark deleted the feat/defer_to_token_env_var_if_exists branch November 18, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jhansen sfc-gh-jhansen sfc-gh-jhansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanebclark @sfc-gh-jhansen