Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DND Arena token added #579

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

DND Arena token added #579

wants to merge 8 commits into from

Conversation

yarscript
Copy link

@yarscript yarscript commented Dec 2, 2024 •
edited
Loading

Please review the following token assets:

📑 Description

✅ Checks

  • I created a new folder with the token address (all in lowercase for EVM chains, case sensitive for Solana)
  • I added the token's logo as a 32x32 PNG file, named logo-32.png
  • I added the token's logo as a 128x128 PNG file, named logo-128.png
  • I added the token's logo as a SVG file, named logo.svg
  • My SVG logo is a proper SVG and not some base64 stuff
  • My documentation/website clearly display the token address somewhere

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tokenassets ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:41pm

@yarscript
Copy link
Author

Hi @Methodic0x when you're available to review the PR?

Majorfi
Majorfi requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@Majorfi Majorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a proper SVG asset for this icon instead of a 2+mb png converted to SVG?
Thanks

@Majorfi Majorfi added the Change Requested Change Requested label Jan 6, 2025
@yarscript
Copy link
Author

yarscript commented Jan 10, 2025 •
edited
Loading

Could you provide a proper SVG asset for this icon instead of a 2+mb png converted to SVG? Thanks

done. pls check it
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majorfi Majorfi Majorfi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Change Requested Change Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarscript @Majorfi