Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbitals continued #98

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Orbitals continued #98

merged 1 commit into from
Nov 17, 2024

Conversation

attipaci
Copy link
Collaborator

  • Tweak enum novas_orbital_system to o contain a proper reference coordinate system instead of just an equator type.
  • Renamed novas_set_orbital_pole() to novas_set_orbsys_pole(), which now takes a coordinate reference system as an input, in line with the above.
  • Exposed existing gcrs_to_tod() and tod_to_gcrs() functions.
  • Added gcrs_to_mod() and mod_to_gcrs() functions for convenience.

@attipaci attipaci added bug Something isn't working enhancement New feature or request labels Nov 17, 2024
@attipaci attipaci self-assigned this Nov 17, 2024
@attipaci attipaci linked an issue Nov 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (2cb5a59) to head (e85a28b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files           8        8           
  Lines        3024     3050   +26     
  Branches      575      575           
=======================================
+ Hits         3015     3041   +26     
  Partials        9        9           
Flag Coverage Δ
unittests 99.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/novas.c 99.62% <100.00%> (+<0.01%) ⬆️
src/super.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb5a59...e85a28b. Read the comment docs.

src/novas.c Fixed Show fixed Hide fixed
@attipaci attipaci force-pushed the orbitals-continued branch 4 times, most recently from 9845f88 to 174377e Compare November 17, 2024 11:36
@attipaci attipaci marked this pull request as ready for review November 17, 2024 12:06
@attipaci attipaci merged commit 6576574 into main Nov 17, 2024
16 checks passed
@attipaci attipaci deleted the orbitals-continued branch November 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add orbital elements processing
1 participant