Headerless xml parsing fix #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinorbgr
reviewed
Apr 19, 2024
| @@ -0,0 +1,252 @@ | |||
| <protocol name="test-protocol"> | |||
There was a problem hiding this comment.
Given this test file is only used to ensure the scanner doesn't choke on it, I don't think it needs to be as big as the main one, it can be much more minimalistic I'd say.
|
LGTM, could you just add an entry to the changelogs of wayland-scanner and wayland-protocols-plasma to reflect those changes ? Also, it looks like rustfmt is unhappy in the CI |
added 2 commits
April 20, 2024 12:41
Fixed fmt issues and added changes to changelogs. |
|
@elinorbgr can you check it pls? Is it ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out some protocols are not available because of parser.
That patch fixes parsing for headerless xml files.
Also I added couple of tests.