Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wayland-protocols to 1.34 #709

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Mar 20, 2024

Adds linux-drm-syncobj-v1.

@ids1024
Copy link
Member Author

ids1024 commented Mar 20, 2024

Oh, I guess there are a couple more protocols to add. That were merge merged since 1.33.

@ids1024
Copy link
Member Author

ids1024 commented Mar 21, 2024

Added the other two protocols, and doc comments.

Copy link
Member

@elinorbgr elinorbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll look at the CI failure that is unreleated, before e merge this.

Adds xdg-toplevel-drag-v1, xdg-dialog-v1, and linux-drm-syncobj-v1.
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@738cef0). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #709   +/-   ##
=========================================
  Coverage          ?   76.16%           
=========================================
  Files             ?       45           
  Lines             ?     8153           
  Branches          ?        0           
=========================================
  Hits              ?     6210           
  Misses            ?     1943           
  Partials          ?        0           
Flag Coverage Δ
main 59.06% <ø> (?)
test-- 81.07% <ø> (?)
test--server_system 64.66% <ø> (?)
test-client_system- 72.18% <ø> (?)
test-client_system-server_system 54.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ids1024
Copy link
Member Author

ids1024 commented Apr 3, 2024

CI is passing after rebasing.

@elinorbgr elinorbgr merged commit d9f2fde into Smithay:master Apr 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants