wayland-backend: raw-window-handle 0.6 #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortuntely we used the `raw-window-handle` feature name for 0.5, which would be a breaking change. To handle this for the future, replicate what winit does and make a new feature for 0.6. The 0.5 version feature is deprecated and will be removed in a later version.
|
The CI failure looks unrelated, could you just add a changelog entry for this as well please? |
|
Actually, the fail of the of "format" job is legit, looks like a trailing space slipped in. |
|
This still needs a changelog entry and formatting fix. But otherwise seems good. |
|
Rebased and merged as part of #732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortuntely we used the
raw-window-handlefeature name for 0.5, which would be a breaking change. To handle this for the future, replicate what winit does and make a new feature for 0.6. The 0.5 version feature is deprecated and will be removed in a later version.