Expand skeleton height config #1156
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make height off max and min tracker positions - Move HMD height to skeleton - Remove full height as it's never used
ButterscotchV
added
Priority: Normal
ButterscotchV
added
the
Status: Blocked by other issue
ButterscotchV
changed the title
This was referenced Sep 17, 2024
ButterscotchV
commented
Oct 7, 2024
Comment on lines
33
to
40
| const beneathFloor = useMemo( | ||
| () => | ||
| !( | ||
| hmdTracker?.tracker.position && | ||
| hmdTracker.tracker.position.y >= MIN_HEIGHT | ||
| ), | ||
| [hmdTracker?.tracker.position?.y] | ||
| ); |
There was a problem hiding this comment.
We should probably only consider this if the headset is connected or not, the height could be very off, but could be correct with the floor height changed. Maybe we could give an option to use the manual height when the smol warning is shown?
There was a problem hiding this comment.
Looks good but any positional head tracker should work, though idk if it matters if we just go for HMD
github-actions
bot
added
Area: Skeletal Model
ButterscotchV
added
the
Difficulty: Large refactor
|
done added all remaining tasks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the basic height configuration that is part of AutoBone with one that includes the floor height. This value is also used when resetting proportions, so you no longer need to be in a specific pose for that.
Requires SlimeVR/SolarXR-Protocol#147.
Remaining tasks:
height - floor > 0.4height - floor > 0.4