Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LSM6DS33 #159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add LSM6DS33 #159

wants to merge 3 commits into from

Conversation

Noxime
Copy link
Collaborator

@Noxime Noxime commented Jan 25, 2023

No description provided.

@Noxime Noxime added the Area: Firmware Relating to the firmware subprojct label Jan 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2023
View reviewed changes
firmware/src/main.rs
@@ -8,6 +8,8 @@
#![feature(alloc_error_handler)]
// We want to do some floating point math at compile time
#![feature(const_fn_floating_point_arithmetic)]
// Asynchronous IMU sampling
#![feature(async_fn_in_trait)]

Check warning

Code scanning / clippy

the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes

the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
firmware/src/imu/driver/lsm6ds33.rs
ticker: Ticker,
}
impl<I: I2c> Lsm6Ds33<I> {
pub fn new(i2c: I) -> Result<Self, lsm6ds33::Error<<I as I2c>::Error>> {

Check warning

Code scanning / clippy

associated function `new` is never used

associated function `new` is never used
@TheButlah
Copy link
Collaborator

TheButlah commented Jan 25, 2023 •
edited
Loading

Will test on my lsm once dependent PRs are merged and this is rebased.

@TheButlah TheButlah added Type: Enhancement A new feature or improvement Status: Needs Hardware Requires testing on hardware to progress labels Jan 25, 2023
@Noxime
Copy link
Collaborator Author

Noxime commented Jan 26, 2023

This has been tested against drop-in compatible LSM6DS3TR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheButlah TheButlah Awaiting requested review from TheButlah TheButlah is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Firmware Relating to the firmware subprojct Status: Needs Hardware Requires testing on hardware to progress Type: Enhancement A new feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noxime @TheButlah