Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual dicom browser enhs #7912

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Visual dicom browser enhs #7912

merged 3 commits into from
Sep 10, 2024

Conversation

Punzo
Copy link
Contributor

@Punzo Punzo commented Aug 30, 2024

New PR for visual DICOM browser enhancements. This is a work in progress.

Depends on:

commontk/CTK#1217

@Punzo Punzo marked this pull request as draft August 30, 2024 11:19
@Punzo Punzo force-pushed the visualDICOMBrowserENH branch 2 times, most recently from 3268e4c to f51596c Compare September 2, 2024 16:31
@Punzo Punzo marked this pull request as ready for review September 2, 2024 16:34
@Punzo
Copy link
Contributor Author

Punzo commented Sep 2, 2024

@lassoan this is ready for review.

@Punzo Punzo force-pushed the visualDICOMBrowserENH branch 3 times, most recently from 30e5549 to 2363a1d Compare September 9, 2024 13:10
@Punzo Punzo marked this pull request as draft September 9, 2024 19:07
@Punzo
Copy link
Contributor Author

Punzo commented Sep 9, 2024

Needs commontk/CTK#1218 to be merged

Revision: 627842c05f262650bf50ff33f8fd31c7f330349a
Author: Davide Punzo <[email protected]>
Date: Thu Aug 29 16:20:02 2024 +0200
Message:
ENH: Improve Visual DICOM browser
ENH: Add job status logging to the detail logging window
ENH: Enable thumbnail generation in worker processes
BUG: Fix missing update of server settings UI
BUG: Add missing Python wrapping methods for ctkJobDetail
ENH: Enhance job logging for better traceability
PERF: Optimize UI updates by directly calling component slots

Revision: f3b6cb628e5cc5652433adfcb5471cfd9a6543e4
Author: Davide Punzo <[email protected]>
Date: Mon Sep 9 19:50:46 2024 +0200
Message:
ENH: Improve Visual DICOM browser
PERF: Improve queue jobs performances by cleaning mutex use
ENH: Improve inserter jobs log report
@Punzo Punzo marked this pull request as ready for review September 10, 2024 15:26
@Punzo
Copy link
Contributor Author

Punzo commented Sep 10, 2024

commontk/CTK#1218 has been merged and I have updated CTK tag here. This is ready for review @lassoan . Thanks!

Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good.

@lassoan lassoan enabled auto-merge (rebase) September 10, 2024 16:11
@lassoan lassoan merged commit 0f9af0c into Slicer:main Sep 10, 2024
5 checks passed
@Punzo Punzo deleted the visualDICOMBrowserENH branch September 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants