fix(executor): Adding silent mode and tests #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at #94, I've notived that the output of `turbolift commit` includes a weird line: ``` Executing: /opt/homebrew/bin/zsh [-c ...] ``` This is because `isRepoChanged` function executes a command to figure out whether something is marked as changed. Every command executed generates an echo of the command for the user. This PR introduces a new flag on the executor that will skip the echo. This fixes the extraneous output in `isRepoChanged` but will also be useful in future features.
sledigabel
commented
Feb 1, 2024
sledigabel
commented
Feb 1, 2024
sledigabel
commented
Feb 1, 2024
Dan7-7-7
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
While looking at #94, I've notived that the output of
turbolift commitincludes a weird line:
This is because
isRepoChangedfunction executes a command to figure out whether something is marked as changed. Every command executed generates an echo of the command for the user.What's changed?
This PR introduces a new flag on the executor that will skip the echo.
This fixes the extraneous output in
isRepoChangedbut will also be useful in future features.It also adds unit tests on the
executorpackage which were missing before.The tests highlighted a race condition that went unnoticed previously and is also now fixed.
Result of the PR
The extra line doesn't print any more.
