Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LMN-1700] Fix the keyboard dismisses automatically while typing in App Search Modal #2064

Conversation

Evelyn-Tang
Copy link
Contributor

@Evelyn-Tang Evelyn-Tang commented Sep 27, 2024

https://skyscanner.atlassian.net/browse/LMN-1700

  • We found that the scroll position of content of App Search Modal changes which results in the keyboard dismiss as unexpected.
  • To resolve it, add extensions to CGFloat and CGPoint to compare the 2 points in a certain number of decimal places.

Before

2024-09-27.17.03.18.mov

After

2024-09-27.16.57.10.mov

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@Evelyn-Tang Evelyn-Tang added the minor Non breaking change label Sep 27, 2024
Copy link
Contributor

@frugoman frugoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the intention of the change. I think it's a bit hacky as picking the right number of digits seems a bit arbitrary.
That said, lets get this fix in until we find a more generic option in the future.

@frugoman frugoman merged commit 394df25 into main Sep 27, 2024
15 checks passed
@frugoman frugoman deleted the bellagio/LMN-1700-fix-keyboard-dismiss-automatically-in-search-modal branch September 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants