Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SalvageHelper #999

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add SalvageHelper #999

merged 1 commit into from
Oct 21, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

No description provided.

@kevinthegreat1 kevinthegreat1 added the new feature This issue or PR is a new feature label Sep 15, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Sep 15, 2024
viciscat
viciscat approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the price threshold could be made configurable (in case of price changes?)

also why the little ContainerSolverManager refactor?

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 17, 2024
@kevinthegreat1
Copy link
Collaborator Author

The little refactor is because I need highlights to also work in the inventory.

@AzureAaron AzureAaron added this to the 1.23.0 milestone Sep 26, 2024
@AzureAaron AzureAaron merged commit 47d0444 into SkyblockerMod:master Oct 21, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Oct 21, 2024
@kevinthegreat1 kevinthegreat1 deleted the salvage-helper branch October 21, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinthegreat1 @viciscat @LifeIsAParadox @AzureAaron