-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title hud refactor #951
Open
kevinthegreat1
wants to merge
58
commits into
SkyblockerMod:master
Choose a base branch
from
kevinthegreat1:title-hud-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Title hud refactor #951
kevinthegreat1
wants to merge
58
commits into
SkyblockerMod:master
from
kevinthegreat1:title-hud-refactor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
added
the
merge conflicts
This PR has merge conflicts that need solving.
label
Sep 4, 2024
kevinthegreat1
force-pushed
the
title-hud-refactor
branch
from
September 15, 2024 17:33
39eb3fb
to
1f6cff2
Compare
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
merge conflicts
This PR has merge conflicts that need solving.
labels
Sep 15, 2024
Note Squash please. |
yes I deleted a lot of files also created the config screen class or whatever
start moving default positioning to their own classes (kinda like the pipelines)
anyway started making the config accessible from yacl config default config based on old config for HUDs
Also rewrite DropdownWidget to make it function properly (sorry kevin)
refactor some init stuff to have less duplicate code
did the todo in TheEnd while I was at it and removed EndHudConfigScreen.java
* Method renaming * Button in Ui & Visuals for config screen * Localization a bit
* Refactor locations * Refactor comparator * Add Javadoc for ASM injection points
LifeIsAParadox
added
merge conflicts
This PR has merge conflicts that need solving.
and removed
reviews needed
This PR needs reviews
labels
Nov 16, 2024
kevinthegreat1
force-pushed
the
title-hud-refactor
branch
from
November 22, 2024 21:29
1f6cff2
to
e92975b
Compare
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
merge conflicts
This PR has merge conflicts that need solving.
labels
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some bugs with dragging, hitbox, scaling, etc.
Cleaned up code.
Depends on #816.
TitleContainerRefactorCompressed.mp4