Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Glow #1050

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Fix Glow #1050

merged 2 commits into from
Nov 16, 2024

Conversation

AzureAaron
Copy link
Collaborator

Makes the glowing effect not apply through walls when custom glow is applied.

  • Fixes mobs rendering as a solid colour when they have a custom glow applied and no mob had a vanilla glow applied
  • Fixes numerous edge cases where the old system had false positives

@AzureAaron AzureAaron added bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function. labels Nov 11, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Nov 11, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit of a shame it breaks rendering for other mobs, would it be possible to change the mixin to be per mob? like save the previous buffer and restore it after, although idk if that's expensive

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Nov 16, 2024
@AzureAaron
Copy link
Collaborator Author

bit of a shame it breaks rendering for other mobs, would it be possible to change the mixin to be per mob? like save the previous buffer and restore it after, although idk if that's expensive

I'm not sure if framebuffers can work this way, the other "easier" solution (theoretically) would be to have two frame buffers but it's complex as everything would need to be adjusted. I think this is fine as is, people don't care too much about seeing their teammates through walls and outside of dungeons glowing isn't used at all (except for dropped items but those aren't too important).

@AzureAaron AzureAaron merged commit 96d7cc8 into SkyblockerMod:master Nov 16, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Nov 16, 2024
@AzureAaron AzureAaron deleted the glow-fix branch November 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority This issue or PR is prioritized, likely due to a significant loss of a function.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants