Add aligned text for tooltips to align multiple lines #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the aligning point could be set dynamically to waste less space when the elements don't fill up the space as much. The 100 point was set based on the museum text, which can get quite long, but other lines are usually near 80 so there's a big gap between the labels and the values. This would also fix potential issues with lines longer than 100px if any such line gets added in the future. |
|
Currently breaks tooltips on REI due to REI handling tooltip component creation manually: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yoinked from #786. Improved it to make it simpler to use and added some documentation.