Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health bars #1028

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Health bars #1028

wants to merge 8 commits into from

Conversation

olim88
Copy link
Contributor

@olim88 olim88 commented Oct 21, 2024

adds health bars above mobs

image

I thought this would be a cool feature hopefully it should work for all mobs have tested most places.

I feel like this might need to be a feature off by default or with different default depending on what people think of this

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Oct 21, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty neat,
would be nice to have an option for the bar to go from green to red like the health text

List<Text> parts = armorStand.getCustomName().getSiblings();
//loop though name and add every part to a new text skipping over the hidden health values
int healthStartIndex = -1;
System.out.println(healthMatcher.group(0).toString()+"testing");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print testing my beloved

*
* @param armorStand updated armorstand
*/
public static void HeathBar(ArmorStandEntity armorStand) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase

*
* @param armorStand armorstand to check the name of
*/
private static void HealthOnlyCheck(ArmorStandEntity armorStand) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase

add fading between colours and fix problems
@Emirlol Emirlol added the new feature This issue or PR is a new feature label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature reviews needed This PR needs reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants