Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: new forgeable pets able to display forge timing #2314

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

gylfirst
Copy link
Contributor

@gylfirst gylfirst commented Nov 5, 2024

Fix the forgeable pets to display their forge times:

  • Remove the LVL_1_LEGENDARY_ from the constants/forge.js file for all the pets.
  • Change the display for pets in the stats/mining.js file.

I simplified the name in the constants, I was thinking about adding Legendary before the pet name, but as they are all of this rarity, I don't know if it's nice. I am waiting for a feedback on this.

EDIT: I modified the armadillo pet as well, since the abilities changed with the last mining update.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 5, 2024
Copy link
Member

@DuckySoLucky DuckySoLucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, didn't test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants