-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cmake compile #124
Conversation
@wbpcode Does this fit envoy side requirements? |
Hmmm, additional build system support for the cpp2sky won't effect envoy. So from envoy's point, I think it's OK. But from the cpp2sky self's point, is these submodule necesssary? If there better way to manager these deps? |
I think I need to explain the reason that this project have added the submodules. Reason two: when I did this task, due to the grpc archive, I could not figure out the tag of grpc. Therefore I added the submodule and checkouted to the specified branch and noted the version in README.md. As for other deps, perhaps, these should be marked. |
Got it, thanks for you explanation. But basically, IMO, I can only accept the |
I understand your considerations. So, in the latest commits, I hava deleted the submodules and updated README.md. BTW, different ways for cmake compile hava also kept in the codes :) |
Thanks for you update. Now we will have a clean tree. (And I am so sorry for the delay, I check your new messaage on my phone and forget to respond. |
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
=========================================
+ Coverage 0 67.96% +67.96%
=========================================
Files 0 26 +26
Lines 0 1030 +1030
=========================================
+ Hits 0 700 +700
- Misses 0 330 +330 see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -31,7 +31,29 @@ cc_binary( | |||
], | |||
) | |||
``` | |||
#### Cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### Cmake | |
#### CMake |
My pleasure! |
@wbpcode It seems the coverage fails. |
Weird, it just success yesterday. Let's try it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. friendly ping @wu-sheng for merge or second review.
New Feature: