Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans some utils #7191

Open
wants to merge 6 commits into
base: dev/feature
Choose a base branch
from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Nov 3, 2024

Description

Cleans up some util classes. This is to reduce the amount of code we have to maintain, while also reducing the use of archaic self-written replacements for common Java equivalents.

  • Classes marked as deprecated for removal:
    • ReversedListView -> Wasn't used.
    • CyclicList -> Wasn't used.
    • BidiMap -> Can be replaced with BiMap. Wasn't used.
    • BidiHashMap -> Can be replaced with BiMap. Wasn't used.
    • Validate -> Can be replaced with Preconditions. The few uses of this class have been changed to use Preconditions.
    • Setter -> Can be replaced with Consumer. Had several uses, but all have been replaced with Consumer. This is not a breaking change as these are functionally equivalent for the user.
    • Predicate -> Can be replaced with Java's Predicate. Wasn't used.
    • CaseInsensitiveString -> Can be replaced with usage of equalsIgnoreCase. Wasn't used.
  • Classes removed
    • Old Slot (ch.njol.skript.util.Slot) -> Has been deprecated since 2018. Wasn't used.
    • SoundUtils -> Wasn't used.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the housekeeping Housekeeping-related issue or task. label Nov 3, 2024
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are duplicated in #6670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Housekeeping-related issue or task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants