Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex replacement #7167

Open
wants to merge 35 commits into
base: dev/feature
Choose a base branch
from
Open

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Oct 29, 2024

Description

Continues #4323.

  • Addressed review requests
  • Added tests

Thanks @AyhamAl-Ali!


Target Minecraft Versions: any
Requirements: none
Related Issues: #6547

AyhamAl-Ali and others added 29 commits September 7, 2021 03:21
- Add regex replace first
- removed unused vars
# Conflicts:
#	src/main/java/ch/njol/skript/effects/EffReplace.java
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 29, 2024
@Efnilite Efnilite mentioned this pull request Oct 29, 2024
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffReplace.java Outdated Show resolved Hide resolved
src/test/skript/tests/syntaxes/effects/EffReplace.sk Outdated Show resolved Hide resolved
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants