-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some test expressions #7142
Add some test expressions #7142
Conversation
There’s Skript/src/main/java/ch/njol/skript/test/runner/EvtTestCase.java Lines 45 to 59 in ba32d7a
|
this is used in like 5 tests, also |
I don't like the removal of the I don't mind having test-%classinfo% but I prefer event-%classinfo% more. I have no say, so I don't want to review this. |
I agree, removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good but no reason to remove the event values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some formatting
# Conflicts: # src/test/skript/tests/syntaxes/conditions/CondIsCharged.sk # src/test/skript/tests/syntaxes/effects/EffSpawn.sk # src/test/skript/tests/syntaxes/expressions/ExprEntities.sk
Description
Adds some test expressions which I felt were missing.
test world
can now be used instead ofworld "world"
test location
can now be used instead ofspawn of world "world"
test block
can now be used instead ofblock at spawn of world "world"
Also adds
event-world
event value.Target Minecraft Versions: any
Requirements: none
Related Issues: none