-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update files to match checkstyle (part 1) #7117
Open
Efnilite
wants to merge
13
commits into
SkriptLang:dev/patch
Choose a base branch
from
Efnilite:fix-checkstyle-1
base: dev/patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
reviewed
Sep 27, 2024
cheeezburga
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some e
s that could be event
s, and switches that could be updated, but if this is just a styling thing then looks good
sovdeeth
requested changes
Sep 30, 2024
src/main/java/ch/njol/skript/hooks/regions/PreciousStonesHook.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/hooks/regions/PreciousStonesHook.java
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
Oct 1, 2024
Moderocky
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates some of the worst offenders, who are least likely to be affected by other PRs.
Removes around 700 violations, or 10% of total.
Target Minecraft Versions: any
Requirements: none
Related Issues: none