Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow delay within the testing system #7095

Conversation

TheLimeGlass
Copy link
Collaborator

@TheLimeGlass TheLimeGlass commented Sep 19, 2024

Description

Disallow delay within the testing system.

Testing System Info:

  • The script testing system happens instantaneous.
  • Anything delayed does not properly get collected after the delay and assertions become useless.
  • JUnit can be delayed.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Pesekjak Pesekjak added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 19, 2024
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Sep 20, 2024
@APickledWalrus APickledWalrus merged commit c8ccc5b into SkriptLang:dev/patch Oct 1, 2024
7 checks passed
@TheLimeGlass TheLimeGlass deleted the enhancement/disable-assertion-delay branch October 3, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants