Block data stuff #7071
Open
Block data stuff #7071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows getting the block data of valid itemtypes - Adds some methods to get the tags and values of a block data - Adds a block data tags expression - Adds block -> block data converter - Changes some variable names in ExprBlockData test
- toBlock(ItemStack): returns the item as a material, or block material - toValidBlock(ItemStack): returns a material or null if the material wouldn't be a block - getValue(BlockData, String): returns the value of the tag on the blockdata if it exists, or null otherwise. Also tries to convert to boolean and integer
- Adds some new examples - Uses new toValidBlock method from BlockDataUtils - Fixes some logic with the get and change methods
|
Might be worth putting this #6087 as a related issue, I don't believe Nylhus is still working on it after about a year |
sovdeeth
requested changes
Sep 12, 2024
src/test/skript/tests/syntaxes/expressions/ExprBlockDataTags.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprBlockDataTags.sk
Outdated
Show resolved
Hide resolved
sovdeeth
added
enhancement
Efnilite
reviewed
Sep 12, 2024
src/test/skript/tests/syntaxes/expressions/ExprBlockDataTags.sk
Outdated
Show resolved
Hide resolved
Moderocky
reviewed
Sep 13, 2024
sovdeeth
requested changes
Sep 13, 2024
src/main/java/ch/njol/skript/expressions/ExprBlockDataTags.java
Outdated
Show resolved
Hide resolved
Efnilite
requested changes
Sep 14, 2024
src/main/java/ch/njol/skript/expressions/ExprBlockDataTags.java
Outdated
Show resolved
Hide resolved
- getValue will now try to match the value to a regex before trying to parse it as an int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some more basic block data support and block data tags to Skript. It introduces a block -> block data converter, which I'm happy to take feedback on.
Stuff that this PR adds:
Stuff that will probably also make it into this PR:
The code in this PR was created without knowledge of SkBee's implementation. At the very end I compared the two, just to see if I had missed anything big, which I (sort of) had. SkBee uses a method,
toBlockForm, which converts some itemstacks whose material isn't a valid block to their respective block form (e.g. wheat seeds -> wheat). I couldn't think of any other way to do this, so it was implemented with Shane's permission.Target Minecraft Versions: 1.13+
Requirements: none
Related Issues: #6087