Return isNegative() and not false, if CondIsWithin is invalid #7038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the fact that CondIsWithin always returns false if:
is within %location% and %location
is null, or if both are in separate worldsis within %entity/chunk/world/block%
Now, it takes into account whether the condition is negated, and returns true or false appropriately.
What was the issue?
Say I have a guard clause like so:
If the condition fails, one would assume that the player is within the two locations. However, this precondition is violated if either of the two locations are not set. As the condition is doomed to always fail if the locations are null (regardless of negation), the following code will still run. This PR fixes this.
Target Minecraft Versions: any
Requirements: none
Related Issues: none