Add worldborders #7006
Open
Add worldborders #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeezburga
reviewed
Aug 29, 2024
src/main/java/ch/njol/skript/expressions/ExprWorldBorderSize.java
Outdated
Show resolved
Hide resolved
Fusezion
suggested changes
Aug 29, 2024
src/main/java/ch/njol/skript/conditions/CondIsInsideWorldBorder.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInsideWorldBorder.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondIsInsideWorldBorder.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderSize.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderSize.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderWarningDistance.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderWarningTime.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderWarningTime.java
Outdated
Show resolved
Hide resolved
|
A lot of chez's stuff might of been repeated he beat me ;( |
…order#getMaxCenterCoordinate
Moderocky
requested changes
Sep 13, 2024
sovdeeth
requested changes
Sep 13, 2024
|
|
||
| @Override | ||
| public String toVariableNameString(WorldBorder border) { | ||
| return toString(border, 0); |
There was a problem hiding this comment.
might want to have a more compressed and guaranteed unique format for variables:
[virtual] worldborder of player/world for example.
There was a problem hiding this comment.
I'm not really sure if I can get a player's name/uuid here but I can add the virtual part
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprWorldBorderSize.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add worldborder syntax to Skript. Continuation of #5229
Player's worldborder is always virtual
Conditions:
Effects:
I don't like the way I am registering the syntax right now with the
ofand'sbut I can't think of a different wayEvents:
Expressions:
Sections:
Waiting on Secspressions! #7037
Target Minecraft Versions: any
Requirements: Paper for worldborder events
Related Issues: #5178, #3848