-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spread effect #6973
base: dev/feature
Are you sure you want to change the base?
Add spread effect #6973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback as I didn't have time to look through the trigger method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValueError: too many values to unpack (expected 2)
moment
looks very useful, nice work pikachu!
src/test/java/org/skriptlang/skript/test/tests/utils/ChangerUtilsTest.java
Outdated
Show resolved
Hide resolved
assert {_2} is 2 with "Spread to {_2} failed" | ||
|
||
test "EffSpread - spreading 9": | ||
spawn a cat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanna call out that, as a professional TypeScript/JS dev and huge Skript user, this is one of the MRs I'm most excited for. Reminds me of the destructuring syntax in JS. Really cool! |
b11d2ca
to
75e2e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spread 1, "a", and pig across (vector length of {_a}), (name of {_b}), and (spawner type of {_c})
let me know if you don't want to support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still in favour of the changes I originally suggested.
Description
Adds a spread effect which can be used to spread a list of objects across multiple settable expressions.
Target Minecraft Versions: any
Requirements: N/A
Related Issues: N/A