Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a cloner to BlockData.
I noticed an issue someone brought forward the other day, when using BlockData, the data is created at parse time.
If you manipulate the data in a command for instance, the original object is manipulated.
EX:
(this uses reflect, as that is what they were using in their for instance)
When running the command several times:
(take note on "facing")
As you can see, the original data is being modified.
Adding a cloner solves this problem.
After this PR:
(that note that "shape" doesn't persist)
Target Minecraft Versions: any
Requirements: none
Related Issues: none