-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic function calling. #6713
base: feature/script-reflection
Are you sure you want to change the base?
Dynamic function calling. #6713
Conversation
Co-authored-by: Patrick Miller <[email protected]>
What about #6254? |
also see #6254 (comment). i have to be honest - i'm not really a fan of reflective capabilities in vanilla skript |
I, too, am not a big fan. |
Sorry if im blanking right now, but why would you even need this in the first place? you could just... run the function? i dont see any point for this atleast in my eyes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some clerical stuff, nice work!
src/main/java/ch/njol/skript/lang/function/DynamicFunctionReference.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
Co-authored-by: sovdee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests failing and unresolved changes
src/main/java/ch/njol/skript/lang/function/DynamicFunctionReference.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to update this since the main PR was merged? Feel free to re-request after
Additions
New types
Obtain function references by name (& source)
Run function references & get results
Little examples
Infrastructure
Road-map of future plans
I'm setting down a bit of API here for future Skript features/addons to use,
especially ones that want to run tasks.
I have a few ideas about what I would like to do with this, but nothing finalised yet.
Target Minecraft Versions: any
Requirements: none
Related Issues: fixes #1265, fixes #5838, requires #6702