Allow any script in using condition.
#6706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
May 29, 2024
sovdeeth
added
the
enhancement
APickledWalrus
requested changes
Nov 20, 2024
src/main/java/ch/njol/skript/conditions/CondIsUsingFeature.java
Outdated
Show resolved
Hide resolved
Moderocky
force-pushed
the
using-condition-improve
branch
from
37c6938
to
ed120f1
Compare
Efnilite
approved these changes
Nov 21, 2024
Moderocky
merged commit a5d1a7e
into
SkriptLang:feature/script-reflection
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original purpose of the
is usingcondition was to be able to test other scripts. Initially, this wasn't really possible (so it just supported the current script) but with script references it is.Based on #6702, the only actual change is in
ch.njol.skript.conditions.CondIsUsingFeature.Target Minecraft Versions: any
Requirements: none
Related Issues: requires #6702