Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Where/Filter and their Inputs in addons #4856

Closed
TheLimeGlass opened this issue Jun 30, 2022 · 4 comments
Closed

Add support for Where/Filter and their Inputs in addons #4856

TheLimeGlass opened this issue Jun 30, 2022 · 4 comments
Labels
core task Tasks that may be handled only by the core developer team. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jun 30, 2022 •
edited
Loading

Suggestion

Add support for Where/Filter and their Inputs for addons.

Having some sorta implementation so that addons can handle their own predicates in syntaxes

(where|that match) \\[<.+>\\]

Mainly the %*classinfo% input so that the addon doesn't have to make their own variant.
@TheLimeGlass TheLimeGlass added priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). feature Pull request adding a new feature. enhancement Feature request, an issue about something that could be improved, or a PR improving something. core task Tasks that may be handled only by the core developer team. and removed feature Pull request adding a new feature. labels Jun 30, 2022
@TPGamesNL
Copy link
Member

The predicate part is just a condition, which addons can register. The input also allows for addon types. What part doesn't support addons yet?

@TheLimeGlass
Copy link
Collaborator Author

The only allowed class for the where filter ExprInput is ExprFilter.

@TPGamesNL
Copy link
Member

Can't addon just create their own ExprInput?

This was referenced Nov 19, 2023
Closed
Merged
Open
@sovdeeth
Copy link
Member

This should be implemented with #6737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core task Tasks that may be handled only by the core developer team. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sovdeeth @TheLimeGlass @TPGamesNL