Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering in ExprItemsIn #4612

Closed
1 task done
Pikachu920 opened this issue Feb 19, 2022 · 1 comment
Closed
1 task done

Add support for filtering in ExprItemsIn #4612

Pikachu920 opened this issue Feb 19, 2022 · 1 comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Pikachu920
Copy link
Member

Suggestion

ExprItemsIn should allow you to filter what type of items you want. For example, instead of doing this:

loop all items in player's inventory:
  loop-item is a sword

you could just do

loop all swords in player's inventory:

Why?

You can currently use the where filter to do this, but this would be prettier

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this suggestion.
@Pikachu920 Pikachu920 mentioned this issue Feb 20, 2022
Merged
@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Feb 20, 2022
@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Nov 19, 2023 •
edited
Loading

Solution #4856

@APickledWalrus APickledWalrus added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheLimeGlass @Pikachu920 @APickledWalrus @TPGamesNL