forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: libbitcoinsv2 with bindings #62
Draft
Sjors
wants to merge
8
commits into
2024/06/sv2_transport
Choose a base branch
from
libbitcoin-sv2
base: 2024/06/sv2_transport
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
Sjors
force-pushed
the
libbitcoin-sv2
branch
7 times, most recently
from
September 13, 2024 13:58
003108d
to
8b36972
Compare
Sjors
force-pushed
the
2024/06/sv2_transport
branch
from
September 19, 2024 14:26
512289a
to
8220337
Compare
Co-Authored-By: Christopher Coverdale <[email protected]>
This commit adds the simplest stratum v2 message. The remaining messages are introduced in later commits. Co-Authored-By: Christopher Coverdale <[email protected]>
This allows us to subclass Transport.
Implemented starting from a copy of V2Transport and the V2TransportTester, modifying it to fit Stratum v2 and Noise Protocol requirements. Co-Authored-By: Christopher Coverdale <[email protected]> Co-Authored-By: Fi3
Sjors
force-pushed
the
2024/06/sv2_transport
branch
from
September 19, 2024 14:40
8220337
to
5fca2c5
Compare
Standalone library with Stratum v2 functionality. TODO: ?
Sjors
force-pushed
the
libbitcoin-sv2
branch
from
September 19, 2024 14:41
8b36972
to
5fb7fad
Compare
Sjors
force-pushed
the
2024/06/sv2_transport
branch
3 times, most recently
from
September 20, 2024 16:21
4c680d6
to
e28078f
Compare
Sjors
force-pushed
the
2024/06/sv2_transport
branch
from
October 4, 2024 12:06
e28078f
to
62b255c
Compare
Bradb4097
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on bitcoin#29346 and bitcoin#30315
TODO: expose
libbitcoinsv2
as C header API for use in external applicationsThis can probably borrow from bitcoin#30595
The goal is that you can do something like:
And then end up with just a
libbitcoinsv2
library for use in some other project. Specific projects I have in mind:Transport
subclass, its (proposed) c++ implementation of Noise, etc.