Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stratum v2 Template Provider common functionality #49

Open
wants to merge 13 commits into
base: 2024/06/sv2_connection
Choose a base branch
from
Open

Stratum v2 Template Provider common functionality #49

wants to merge 13 commits into from

Conversation

Sjors
Copy link
Owner

@Sjors Sjors commented Jul 19, 2024 •
edited
Loading

Moved from bitcoin#30475.

Based on:

And the following interface changes:

This contains all Template Provider functionality that can be used by both #68 and the IPC based sidecar alternative #48.

This was referenced Jul 19, 2024
Open
Open
Closed
Closed
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from 3cf779b to b549fd6 Compare August 8, 2024 16:13
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch 2 times, most recently from 6894e23 to fc6ac1e Compare August 13, 2024 13:48
@Sjors
Copy link
Owner Author

Sjors commented Aug 13, 2024

Updated to the latest interface changes proposed in bitcoin#30409 and #53.

@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from b549fd6 to 22d033c Compare August 13, 2024 17:14
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch 2 times, most recently from 491755c to 16d2381 Compare August 13, 2024 18:07
@Sjors Sjors mentioned this pull request Aug 26, 2024
Open
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch 3 times, most recently from 4f957ee to b69544c Compare August 29, 2024 11:49
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch 2 times, most recently from ca73422 to 4fa25e0 Compare August 29, 2024 11:59
@Sjors
Copy link
Owner Author

Sjors commented Aug 29, 2024

Rebased for CMake

@Sjors Sjors mentioned this pull request Aug 29, 2024
Closed
@Sjors
Copy link
Owner Author

Sjors commented Aug 30, 2024

One test still seems brittle:

src/test/sv2_template_provider_tests.cpp(256): fatal error: in "sv2_template_provider_tests/client_tests": critical check tester.GetBlockTemplateCount() == 3 has failed [2 != 3]

@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from b69544c to 1ca68d2 Compare September 5, 2024 12:57
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from 1f720ff to 1912743 Compare September 5, 2024 15:56
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from 1ca68d2 to b578e0a Compare September 10, 2024 14:54
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch 2 times, most recently from 598f08a to 436dc4d Compare September 11, 2024 05:39
@Sjors
Copy link
Owner Author

Sjors commented Sep 11, 2024

Moved TemplateProvider from node to common so that in #48 bitcoin-mine does not depend on bitcoin-node.

@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from 436dc4d to 46fa8f1 Compare September 11, 2024 06:37
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from b578e0a to 489c9fb Compare September 19, 2024 15:02
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch 2 times, most recently from 7db898e to 765af74 Compare September 19, 2024 16:13
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from e59ea4f to 735e934 Compare November 25, 2024 13:30
@Sjors
Copy link
Owner Author

Sjors commented Nov 25, 2024

I got rid of the NewWorkSet struct and BuildNewWorkSet helper, moved some repeating code to SendWork.

I also noticed that with -DCMAKE_BUILD_TYPE=Debug the sv2_template_provider_tests run much faster than with the regular build.

This was referenced Dec 2, 2024
Open
Closed
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from 735e934 to c413ad7 Compare December 2, 2024 19:06
@Sjors
Copy link
Owner Author

Sjors commented Dec 2, 2024

Included changes from #72 which fixes a crash and the test run at normal speed again.

@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from c413ad7 to 9cac0b8 Compare December 2, 2024 20:00
@Sjors
Copy link
Owner Author

Sjors commented Dec 2, 2024 •
edited
Loading

Oops, lost the std::this_thread::sleep_for(1ms); line in rebase: https://github.com/Sjors/bitcoin/compare/c413ad7ef45ba7db2c421717c089daed359f6efd..9cac0b8d1e84aa86301fd1e7907aaeeaeb351600

@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from 9cac0b8 to fd26e38 Compare December 16, 2024 04:41
@Sjors
Copy link
Owner Author

Sjors commented Dec 16, 2024 •
edited
Loading

Included a fix for #74: https://github.com/Sjors/bitcoin/compare/9cac0b8d1e84aa86301fd1e7907aaeeaeb351600..fd26e38c2af8ce82a95971392e85d5d23d3fd828

Also updated the list of interface changes in the PR description.

@Sjors Sjors force-pushed the 2024/06/sv2_connection branch 2 times, most recently from ce785e2 to 4eb05e2 Compare December 19, 2024 02:14
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from fd26e38 to a2882d8 Compare December 19, 2024 02:26
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from 4eb05e2 to 4ba3ba8 Compare December 19, 2024 03:05
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from a2882d8 to 51fdf1d Compare December 19, 2024 03:07
@Sjors Sjors force-pushed the 2024/06/sv2_connection branch from 4ba3ba8 to a3a7a46 Compare December 19, 2024 06:12
Sjors and others added 13 commits December 19, 2024 13:13
@Sjors
Make m_tip_block an std::optional
9c1da87 
This change avoids ambiguity when no tip is connected and it is
compared to uint256::ZERO.
@Sjors
Ensure m_tip_block is never ZERO
5486c19 
To avoid future code changes from reintroducing the ambiguity fixed
by the previous commit, mark m_tip_block private and Assume that
it's not set to uint256::ZERO.
@Sjors
test: use Mining interface in miner_tests
a464787 
Alternate calls between Chainman's ProcessNewBlock and submitSolution. The Chainman code path is used in production, so it's important to keep test coverage for it.

Use createNewBlock via the interface instead of using the BlockAssembler directly. The latter is always called via the interface in production code.
@Sjors
Add waitNext() to BlockTemplate interface
7227d01
@Sjors @ccdle12
Stratum v2 template provider scaffold
32d753d 
The template provider will listen for a Job Declarator client.
It can establish a connection and detect various protocol errors.

Co-Authored-By: Christopher Coverdale <[email protected]>
Co-Authored-By: Fi3
@Sjors @ccdle12
Chainparams: add default sv2 port
88b4d2f 
Co-authored-by: Christopher Coverdale <[email protected]>
@Sjors
Add remaining sv2 messages for TemplateProvider
543665b
@Sjors
Sv2: construct and submit block templates
f481d65 
Determine future_template only once
@Sjors
Handle REQUEST_TRANSACTION_DATA
f315fd6
@Sjors
Handle SUBMIT_SOLUTION
4c2b3f1
@Sjors
Incrementally update sv2 block template
f8ebcbb
@Sjors @vasild
CKey: add Serialize and Unserialize
ef523cd 
Co-authored-by: Vasil Dimov <[email protected]>
@Sjors
Persist static key for Template Provider
91ea715
@Sjors Sjors force-pushed the 2024/07/sv2-tp-common branch from 51fdf1d to 91ea715 Compare December 19, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sjors