[Angular] *scRouterLink breaks link generation (#815)

* Strip querystring params from ScRouterLink href * Update tests for router-link * Use navigateByUrl instead
Sitecore · Sep 16, 2021 · c75d0de · c75d0de
1 parent d509fc5
commit c75d0de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/sitecore-jss-angular/src/components/router-link.directive.spec.ts b/packages/sitecore-jss-angular/src/components/router-link.directive.spec.ts
@@ -115,6 +115,7 @@ describe('<a *scRouterLink />', () => {
     fixture.detectChanges();
 
     const rendered = de.query(By.css('a'));
+    expect(rendered.nativeElement.href).toContain(field.value.href);
     expect(rendered.nativeElement.className).toContain(field.value.class);
     expect(rendered.nativeElement.title).toContain(field.value.title);
     expect(rendered.nativeElement.target).toContain(field.value.target);

diff --git a/packages/sitecore-jss-angular/src/components/router-link.directive.ts b/packages/sitecore-jss-angular/src/components/router-link.directive.ts
@@ -34,7 +34,7 @@ export class RouterLinkDirective extends LinkDirective {
 
         if (key === 'href') {
           this.renderer.listen(node, 'click', (event) => {
-            this.router.navigate([propValue]);
+            this.router.navigateByUrl(propValue);
             event.preventDefault();
           });
         }