Fix permissions on arm processors and prepare for permissions change #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works around a bug in luajit that seems to happen when passing a number to `bit.bor` that is larger than 2^31-1 Additionally adds a few missing enumerations so that enableAll and disableAll work as expected. Fixes SinisterRectus#384
|
I've been using this fix for a few weeks now and it has seen a lot of use. So far there haven't been any problems with it, though through testing I found out that when there is an enum missing in libs/enums.lua (for example when discord decides to add a new one on their end), then the permission management breaks again. |
|
It looks like this changes the enum type from number to LJ int. Not ideal, but is there no better way? |
|
Closing as wont-fix. arm32 is relatively rare, and nobody has complained since the original report. Additionally, this introduces a lot of other type-related issues and discord has stopped claiming that they'll stop at 64 bit integers so a better solution will need to be implemented in 3.0 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around a bug in luajit that seems to happen when passing a
number to
bit.borthat is larger than 2^31-1Additionally adds a few missing enumerations so that enableAll and
disableAll work as expected.
Fixes #384
Also forces permissions to be sent as a string, in preparation for
when they'll no longer be allowed to be sent as a number.