2.x: Client option to log full reason for HTTP errors #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review and possibly include this after 2.11.0. |
| client:error('%i - %s : %s %s', res.code, res.reason, method, url) | ||
| local errMsg = f('%i - %s : %s %s', res.code, res.reason, method, url) | ||
| if self._logFullErrors then | ||
| errMsg = errMsg .. "\n" .. msg |
There was a problem hiding this comment.
Shouldn't need to concat here. Take advantage of the logger's formatter.
There was a problem hiding this comment.
I'm not sure what you mean. Something like
if logFullErrors then
client:error(errMsg)
else
client:error("%s\n%s", errMsg, msg)
end?
libs/client/API.lua
Outdated
| self._client = client | ||
| self._mutexes = setmetatable({}, mutexMeta) | ||
| self._logFullErrors = logFullErrors |
There was a problem hiding this comment.
Don't store this here. Just use the options table in the commit method.
RiskoZoSlovenska
force-pushed
the
2.x-full-http-errors
branch
from
743205b to
2290a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x backport of #319.