Logger pretty newlines #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/utils/Logger.lua
Outdated
| line[5] = gsub( | ||
| line[5], | ||
| '\r?\n', | ||
| '%0' .. rep(' ', #line[1] + 16 - 2) .. '| ' -- Timestamp + label (10) + separators (6) |
There was a problem hiding this comment.
Can you show where you get 16 from? We probably shouldn't hardcode this if it can be dynamically generated (maybe as a module local value).
There was a problem hiding this comment.
The label (line[3]) is always length 10. The two separators (|) (line[2] and line[4]) are both 3, so 6 total.
There was a problem hiding this comment.
We probably shouldn't hardcode this if it can be dynamically generated (maybe as a module local value).
Can you make this happen?
There was a problem hiding this comment.
Something like this?
75018a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
booleanclient optionprettyNewlines(trueby default) and a newLoggeroption + mutators which, whentrue, makes the logger pad newlines so that they align with the timestamp label. This is just a cosmetic change to make logging multi-line strings neater.As an example, what before was:
now becomes: