SinguloStation essentials #2
Conversation
There was a problem hiding this comment.
Changelog is missing authors (AFAIK crediting original code authors in some way is a requirement of the license, not sure why I thought that, seems like it's not based on license, but usually required by listing them out somewhere, but SS13 codebases also accept co-authors on commits, like when cherry-picking)
Changelog is missing changes (no mention of protolathe/techfab/circuit imprinter changes, lacking information on what was actually done to cryo, other changes to things like tracking player login/logout)
Waiting on MDB and IDB to preview new map and check icon changes.
I'd also recommend testmerging this for a test run before it's merged, could get messy due to the lack of atomization.
Co-authored-by: KubeRoot <[email protected]>
code/modules/antagonists/traitor/objectives/locate_weakpoint.dm.old
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Approved, noting my recommendations that have been dismissed:
- I think we should avoid modifying files where not necessary, in this case runtimestation - resolving conflicts on that would get very annoying.
- I think you shouldn't rename the locate_weakpoint file and instead comment out the entire thing, once again for conflict reasons.
I will also note there's still multiple places where singulo-specific code is not marked, but that doesn't affect how the code runs, and my understanding is that you want to handle merges yourself, so that's up to you.
The changelog was also never completed despite my suggestion, but as long as attribution information is correct, I don't really care.
| @@ -176,10 +176,10 @@ GUEST_BAN | |||
| # WIKIURL http://www.tgstation13.org/wiki | |||
|
|
|||
| ## Rules address | |||
| # RULESURL http://www.tgstation13.org/wiki/Rules | |||
| RULESURL https://discord.gg/yjCSCzzezp | |||
There was a problem hiding this comment.
Putting your rules on discord seems like a bad idea and dick move for anybody who doesn't want to use discord, but config is your territory.
There was a problem hiding this comment.
Yes, that needs to be changed in the future; we're moving the rules to the wiki anyway.
About The Pull Request
Adds cryo and the first map, Xyraeon-9b.
Why It's Good For The Game
literally necessary for the server to launch
Changelog
🆑 Terra1, KubeRoot, TheOneAndMightyRed, Urumasi, MaltVinegar, tgstation devs (tralezab), WhiteSands devs (AsciiSquid, MarkSuckerberg, Superyodeler)
add: Cryogenics code.
add: Printable protolathes and techfabs.
add: Xyraeon-9b.
config: Configuration adjusted for SinguloStation.
/:cl: