This repository has been archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] Refactors area moods to optionally restrict to jobs (+ new area moods!) #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…!) (#7502) * refactoring stuff * ze messagse + fix * removes debug msg * various fix * fix and warden * when you forget to remove your dupe * syntaxical fix * minor chang * wikistrings and misc job fixes * finalfix * refactors again so each area can have its own unique check in a proc! * forgot to replace it with implied src * explicit returns * Update code/game/area/Space_Station_13_areas.dm Co-authored-by: PowerfulBacon <[email protected]> * Update code/game/area/Space_Station_13_areas.dm Co-authored-by: PowerfulBacon <[email protected]> * Update code/game/area/Space_Station_13_areas.dm Co-authored-by: PowerfulBacon <[email protected]> Co-authored-by: Candycaneannihalator <[email protected]> Co-authored-by: etherware-novice <[email protected]> Co-authored-by: PowerfulBacon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7502
About The Pull Request
Refactored how the area mood system works, now theres a list var called mood_job. It defaults to an empty list, and if unset, will not affect how the mood is run. If its set, it will check whether someones mind.assigned_role is in the list, and grant the mood if it is.
As a demonstration, I added a few role restricted mood buffs to armory (assistant), ai upload (assistant, rd, captain), and telecomms (rd, scientist, roboticist)
Why It's Good For The Game
More variety for area moods, its just fun in general
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
refactor: area mood buffs can now be applied to only certain jobs
add: added new job restricted area mood buffs
/:cl: