Selector bug, discovered from #4

SimulatedGREG · Apr 25, 2016 · 9c02ceb · 9c02ceb
1 parent f1af903
commit 9c02ceb
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/dist/kappa.js b/dist/kappa.js
@@ -97,7 +97,10 @@
       for (var emote in KappaJS.emotes) {
         if (KappaJS.emotes.hasOwnProperty(emote)) {
           $(self).each(function () {
-            $(self).html($(self).html().replace(new RegExp('\\b' + emote + '\\b', 'g'), generateImgTag(KappaJS.emotes[emote], emote)));
+            // NOTE: Transpiler bug
+            // Next 2 selector should be `this`, but babel grab context of `replaceTextWithEmotes` function
+            // Manually adjusted in build until futher notice.
+            $(this).html($(this).html().replace(new RegExp('\\b' + emote + '\\b', 'g'), generateImgTag(KappaJS.emotes[emote], emote)));
           });
         }
       }
@@ -112,4 +115,4 @@
       waitKappaJS();
     } else replaceTextWithEmotes();
   };
-})(jQuery);
+})(jQuery);
diff --git a/dist/kappa.min.js b/dist/kappa.min.js
diff --git a/index.html b/index.html
@@ -5,10 +5,14 @@
     <title>Kappa.js</title>
   </head>
   <body>
-    <div class="kappa">Kappa FailFish WutFace</div>
+    <div>
+      <span class="kappa">Kappa</span>
+      <span class="kappa">FailFish</span>
+      <span class="kappa">WutFace</span>
+    </div>
 
     <script src="https://code.jquery.com/jquery-2.2.0.min.js"></script>
-    <script src="dist/kappa.js"></script>
+    <script src="dist/kappa.min.js"></script>
 
     <script>
       $(document).ready(function() {

diff --git a/src/kappa.js b/src/kappa.js
@@ -105,6 +105,9 @@
       for (var emote in KappaJS.emotes) {
         if (KappaJS.emotes.hasOwnProperty(emote)) {
           $(self).each(() => {
+            // NOTE: Transpiler bug
+            // Next 2 selector should be `this`, but babel grab context of `replaceTextWithEmotes` function
+            // Manually adjusted in build until futher notice.
             $(self).html(
               $(self).html().replace(
                 new RegExp('\\b' + emote + '\\b', 'g'),