Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunchboxes! Revival #64

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #980: Lunchboxes! Revival from DeltaV-Station DeltaV-Station/Delta-v

PR opened by

DebugOk at 2024-03-19 11:23:47 UTC PR merged by

DebugOk at 2024-03-19 11:39:39 UTC

9ad761ae18818a8842b3a60c63cfff0b92b18e85


PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:

  • Changes: YML
  • Changes: Localization
  • Changes: Sprite

Original Body

The following is copied from #716, but with the sprites all put into a single .RSI file

About the PR

Added Lunchboxes
Added pre-filled Lunchboxes, containing a few snacks.

Why / Balance

Variety, lets the chef pack meals for people that they can take with them, rather than leaving food on the kitchen counter!
Also a new storage item, for people to use nested inventory or for people to hide evil items in.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

Changelog
🆑 DangerRevolution and Noctis

  • add: Added lunchboxes to the chefvend and dinnerwarevend for the Chef to fill or hand out pre-made!

Copy link
Contributor

github-actions bot commented Apr 7, 2024

RSI Diff Bot; head commit 5bc0f73 merging into b702cbd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Storage/lunchbox.rsi

State Old New Status
command-inhand-left Added
command-inhand-right Added
command-open Added
command Added
engineering-inhand-left Added
engineering-inhand-right Added
engineering-open Added
engineering Added
epistemics-inhand-left Added
epistemics-inhand-right Added
epistemics-open Added
epistemics Added
generic-inhand-left Added
generic-inhand-right Added
generic-open Added
generic Added
logistics-inhand-left Added
logistics-inhand-right Added
logistics-open Added
logistics Added
medical-inhand-left Added
medical-inhand-right Added
medical-open Added
medical Added
security-inhand-left Added
security-inhand-right Added
security-open Added
security Added
service-inhand-left Added
service-inhand-right Added
service-open Added
service Added
syndicate-inhand-left Added
syndicate-inhand-right Added
syndicate-open Added
syndicate Added

@VMSolidus VMSolidus merged commit 81bc8be into Simple-Station:master Apr 8, 2024
13 checks passed
VMSolidus added a commit to VMSolidus/Einstein-Engines that referenced this pull request Apr 12, 2024
@Pspritechologist Pspritechologist added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
zelezniciar1 added a commit to zelezniciar1/Einstein-Engines that referenced this pull request Oct 30, 2024
)

<!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- The text between the arrows are comments - they will not be visible
on your PR. -->

## About the PR
<!-- What did you change in this PR? -->
Almost fully readded the PK, only missing a couple sprites before it can
be mapped.
Renamed the projectiles.
## Why / Balance
<!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
It was removed in WizDen
[#8301](space-wizards/space-station-14#8301) to
"cull excess".
Personally, we can always use more gun, and I renamed the projectiles
because it was annoying trying to figure out what shot what.
## Technical details
<!-- If this is a code change, summarize at high level how your new code
works. This makes it easier to review. -->
Nothing but YAML.
## Media
<!-- 
PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
Small fixes/refactors are exempt.
Any media may be used in SS14 progress reports, with clear credit given.

If you're unsure whether your PR will require media, ask a maintainer.
-->

## Requirements
<!-- 
Due to influx of PR's we require to ensure that PR's are following the
correct guidelines.

Please take a moment to read these if its your first time.

Check the boxes below to confirm that you have in fact seen these (put
an X in the brackets, like [X]):
-->
- [x] I have read and I am following the [Pull Request
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
I understand that not doing so may get my pr closed at maintainer’s
discretion
- [x] I have added screenshots/videos to this PR showcasing its changes
ingame, **or** this PR does not require an ingame showcase

## Breaking changes
<!--
List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
-->

**Changelog**
<!--
Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
-->
:cl:
- add: Readded the PK partially, pending further spriting.
- fix: Fired .30 Rifle rounds are now actually named .30 rifle rounds.
<!--
Make sure to take this Changelog template out of the comment block in
order for it to show up. Changelog must have a :cl: symbol, so the bot
recognizes the changes and adds them to the game's changelog.
:cl:
- add: Added fun!
- remove: Removed fun!
- tweak: Changed fun!
- fix: Fixed fun!
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants