-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display an Alert when the User Is Walking or Running. #528
Conversation
glue |
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: gluesniffler <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: gluesniffler <[email protected]>
…a Short, added this ugly cast on both sides
Why do first-time contribs need checks approved? This is stupid. |
Resolved, re-requesting review.
It's to prevent pro contributors from replacing Content.IntegrationTests with a bitcoin miner (there were incidents). |
yea |
that's fucking hilarious 😭😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
First PR. Adds an alert on the user UI whenever they toggle between walking or running. No more second guessing whether you will slip or not when walking over that puddle of water, or if your usage of Shift on chat toggled your movement speed.
The alert is displayed for entities with the component 'CanWalkComponent', which is added to the following prototypes:
Media
2024-07-08.04-29-20.mp4
Future Stuff
I also wanted to make it toggle the user's speed on click like it would in ss13, but sadly the majority of the input management/prediction seems to be done exclusively client-side, making it a hassle to work around the alert. Will revisit if there's improvements or refactors to the movement code.
Changelog
🆑