Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an Alert when the User Is Walking or Running. #528

Merged
merged 12 commits into from
Jul 16, 2024

Conversation

gluesniffler
Copy link
Contributor

@gluesniffler gluesniffler commented Jul 8, 2024

Description

First PR. Adds an alert on the user UI whenever they toggle between walking or running. No more second guessing whether you will slip or not when walking over that puddle of water, or if your usage of Shift on chat toggled your movement speed.

The alert is displayed for entities with the component 'CanWalkComponent', which is added to the following prototypes:

  • All genetic ancestors (MobBaseAncestor)
  • Human controlled mechs (BaseMech, wont display on VIMs or HAMTRs because rats or hamsters can't walk, and the edge case is not worth the trouble)
  • All human/player species (BaseMobSpeciesOrganic)
  • All slimes/geras (BaseMobAdultSlimes)
  • Reagent Slimes (ReagentSlime)
  • Rat Kings (MobRatKing - yes they can fucking walk lmao)
  • Borgs (BaseBorgChassis)

Media

2024-07-08.04-29-20.mp4


Future Stuff

I also wanted to make it toggle the user's speed on click like it would in ss13, but sadly the majority of the input management/prediction seems to be done exclusively client-side, making it a hassle to work around the alert. Will revisit if there's improvements or refactors to the movement code.


Changelog

🆑

  • add: Added an alert on the UI for when the user is walking or running.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Jul 8, 2024
@SimpleStation14 SimpleStation14 changed the title Display an alert when the user is walking or running. Display an Alert when the User Is Walking or Running. Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

RSI Diff Bot; head commit 3046cee merging into 3178ccb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Alerts/walking.rsi

State Old New Status
walking0 Added
walking1 Added

Edit: diff updated after 3046cee

@DEATHB4DEFEAT
Copy link
Member

glue

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point labels Jul 9, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: gluesniffler <[email protected]>
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DangerRevolution
Copy link
Contributor

Why do first-time contribs need checks approved? This is stupid.

@DangerRevolution DangerRevolution dismissed DEATHB4DEFEAT’s stale review July 11, 2024 19:59

Resolved, re-requesting review.

@Mnemotechnician
Copy link
Contributor

Why do first-time contribs need checks approved? This is stupid.

It's to prevent pro contributors from replacing Content.IntegrationTests with a bitcoin miner (there were incidents).

@DEATHB4DEFEAT
Copy link
Member

yea

@DangerRevolution
Copy link
Contributor

Why do first-time contribs need checks approved? This is stupid.

It's to prevent pro contributors from replacing Content.IntegrationTests with a bitcoin miner (there were incidents).

that's fucking hilarious 😭😭

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

PR is not working as advertised, as determined in testing. The toggle walk works, but the UI element for displaying Walk vs. Run does not appear. This should be fixed before this PR can be merged.

@gluesniffler gluesniffler requested a review from VMSolidus July 16, 2024 21:35
@VMSolidus VMSolidus merged commit 62dfbfc into Simple-Station:master Jul 16, 2024
15 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants