-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port All Carrying/PseudoItem/EscapeInventory Tweaks From DeltaV #484
Port All Carrying/PseudoItem/EscapeInventory Tweaks From DeltaV #484
Conversation
…dental escape from carrying
Better fix Simple-Station#1
…y them, also allows to insert the carried person into a bag)
* fixie * Prettier code * Bleugh (cherry picked from commit 380c85847600d60dee104b6ee0fc7ef8dbe41b51)
I haven't given this a deeper look than only a cursory glance, but I'm fascinated by the fact that this system for whatever baffling reason has its own private implementation of the original (bad) MassContest code. This is itself terrible, and it's not even the fault of the DeltaV PR, they're just swapping multiply with divide. I'm not going to deny moving it here because of that, but whichever comes first, this or the Reworked Mass Contests, the other is getting changed and I'm yeeting the damn carrying system implementation of Old MassContest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should all be in base game folders with comments removed
Description
This cherry-picks the following two PRs of mine from delta-v:
Encompassing a total of 8 distinct changes:
For technical details and video showcases, see the original PRs
This PR is split into separate commits so different parts can be reverted if deemed unneccessary.
Changelog
🆑