Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Item Transfer System #475

Closed
wants to merge 2 commits into from

Conversation

Spatison
Copy link
Contributor

@Spatison Spatison commented Jun 18, 2024

Description

This PR adds the ability to transfer objects from hand to hand, as in SS13.
I have little coding experience, so my solutions may not be ideal.


TODO

  • Make the code work
  • Add popup
  • Write a summary of the code
  • Сorrect inaccuracies

Media

https://youtu.be/zTQWTsYm1gw


Changelog

🆑

  • add: Added system

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Jun 18, 2024
@SimpleStation14 SimpleStation14 changed the title Add Item transfer system Add Item Transfer System Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

RSI Diff Bot; head commit b5a1617 merging into b04fb61
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/give_item.rsi

State Old New Status
give_item Added

Edit: diff updated after b5a1617

@DEATHB4DEFEAT
Copy link
Member

Very cool.

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No verbs should be gerunds

@@ -68,6 +68,7 @@ public static void SetupContexts(IInputContextContainer contexts)
human.AddFunction(ContentKeyFunctions.SmartEquipBelt);
human.AddFunction(ContentKeyFunctions.OpenBackpack);
human.AddFunction(ContentKeyFunctions.OpenBelt);
human.AddFunction(ContentKeyFunctions.OfferingItem);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be OfferItem everywhere instead of OfferingItem.

/// </summary>
[UsedImplicitly]
[DataDefinition]
public sealed partial class AcceptingOffer : IAlertClick
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be AcceptOffer

@DangerRevolution
Copy link
Contributor

Hello, can I edit this PR to be more accurate in English? You can send me the Russian version of what you want this post to say and I can try accurately translate :)

@Spatison Spatison closed this Jun 18, 2024
@Spatison Spatison deleted the OfferingItem branch June 18, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants