Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Re-resprites labcoats #389

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26425: Re-resprites labcoats from space-wizards space-wizards/space-station-14

bd58954d4e1612e7aeff7b80ff27eeeed1c474f8

PR opened by Flareguy at 2024-03-25 08:52:12 UTC


PR changed 83 files with 21 additions and 69 deletions.

The PR had the following labels:

  • No C#
  • Changes: Sprites

Original Body

About the PR

Uncooked version of #26209.
Completely reshades most labcoats and gives them new inhands.
Does not touch senior labcoats. They're unused, their designs suck, and I don't feel like making new ones right now.

This PR also used to remove the geneticist labcoat, but I'll probably just kill that in another PR. Recoloring it took like 2 minutes and removing it in this PR is more effort then it's worth.

Why / Balance

With a year's worth of experience under my belt after I made the previous iteration of these, I felt like these could use a touchup to make them more fitting & more detailed. The old ones had a comically low colorcount and slightly unfitting minor hueshifting, along with the added / changed shading hopefully just being an improvement compared to the old ones.

Media

Content Client_vxGsqDMulJ

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

This renames rd_labcoat.rsi and rnd_labcoat.rsi to be consistent with the rest of the labcoats. It is unlikely anything will break from this, though.

Changelog

  • tweak: Resprited labcoats.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

RSI Diff Bot; head commit 2bc7000 merging into b68ed3c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/OuterClothing/Coats/labcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_chem.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_cmo.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
open-equipped-OUTERCLOTHING Modified
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_gene.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_robo.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_viro.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon-open Modified
icon Modified
inhand-left Modified
inhand-right Modified
open-equipped-OUTERCLOTHING Modified
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/rd_coat.rsi

State Old New Status
equipped-OUTERCLOTHING Removed
icon-open Removed
icon Removed
inhand-left Removed
inhand-right Removed
open-equipped-OUTERCLOTHING Removed
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/rndcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Removed
icon-open Removed
icon Removed
inhand-left Removed
inhand-right Removed
open-equipped-OUTERCLOTHING Removed
open-inhand-left Removed
open-inhand-right Removed

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_rd.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added

Resources/Textures/Clothing/OuterClothing/Coats/labcoat_sci.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added

@DangerRevolution DangerRevolution self-assigned this May 4, 2024
@DangerRevolution DangerRevolution added Changes: YML Changes any yml files Size: 4-Small For small issues/PRs Priority: 5-Whenever Doesn't matter when this gets resolved Changes: Sprite Changes any png or json in an RSI Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Status: Do Not Merge Do not merge labels May 4, 2024
@DangerRevolution
Copy link
Contributor

consensus seems to be that these labcoats are well-sprited. this PR would need to remove the Delta coats from the game if merged as is :O

@FoxxoTrystan
Copy link
Member

If i could modify this PR, i shall.

@DangerRevolution
Copy link
Contributor

Just going to close it; if someone wishes to resprite things they can do so, pulling textures from wherever they wish and the Delta coats are good enough.

Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 5-Whenever Doesn't matter when this gets resolved Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Do Not Merge Do not merge Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants