Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Give cap door remote his access #357

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26378: Give cap door remote his access from space-wizards space-wizards/space-station-14

ea818ea1b6d910fb1b86ee06648fc0da5a100a27

PR opened by Baptr0b0t at 2024-03-24 05:03:38 UTC


PR changed 1 files with 2 additions and 2 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

Add access to the command door remote.

Why / Balance

Because of #26371
The command remote control becomes useless and cannot access most doors

Technical details

YML configuration, change access group of command door remote

Media

  • this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Fix access of command door remote.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 19:28
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works... but.
This looks EXTREMLY OP.

Are we sure we want this with "AllAccess"?

@DangerRevolution DangerRevolution requested a review from a team May 11, 2024 01:10
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 11, 2024
@DangerRevolution DangerRevolution added Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed and removed Status: Needs Review Someone please review this labels May 11, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding, it was changed in another PR that remotes no longer inherit the access from your ID. So it's just that remote and whatever access it's given to stop a service remote with an AA ID being powerful.

But uh, I don't see why this should have AA? But I also see the use in an AA Remote for the Captain? Not sure but I'll approve.

@DangerRevolution
Copy link
Contributor

This is intended to be merged with #315

@VMSolidus VMSolidus merged commit 2f6ab4a into Simple-Station:master May 11, 2024
21 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants